summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorintrigeri <intrigeri@boum.org>2019-04-08 09:00:59 +0000
committerintrigeri <intrigeri@boum.org>2019-04-08 09:04:07 +0000
commit13cc510f7f0dd30af8ce74799a4e2c506cdc91dc (patch)
treec115e8933b94a9690d79a38128eafceb13972338
parent9ffe2dceb2563fafa8c95e195ce7cf8ac41b790a (diff)
Test suite: remove tests that exercise Gobby or otherwise rely on it (refs: #15291)
We lose the "Explicitly torify-wrapped applications are using the default SocksPort" and "Explicitly torsocks-wrapped applications are using the default SocksPort" scenarios along the way. We could of course rewrite them to test something else than Gobby but I see very little value in it: in practice, they merely test that the default configuration of torsocks and torify is what it has been since these pieces of software were created.
-rw-r--r--features/step_definitions/tor.rb24
-rw-r--r--features/tor_stream_isolation.feature21
2 files changed, 0 insertions, 45 deletions
diff --git a/features/step_definitions/tor.rb b/features/step_definitions/tor.rb
index f9d2938..5068e09 100644
--- a/features/step_definitions/tor.rb
+++ b/features/step_definitions/tor.rb
@@ -262,11 +262,6 @@ def stream_isolation_info(application)
:socksport => 9150,
:controller => true,
}
- when "Gobby"
- {
- :grep_monitor_expr => 'users:(("gobby-0.5"',
- :socksport => 9050
- }
when "SSH"
{
:grep_monitor_expr => 'users:(("\(nc\|ssh\)"',
@@ -323,25 +318,6 @@ And /^I re-run tails-upgrade-frontend-wrapper$/ do
$vm.execute_successfully("tails-upgrade-frontend-wrapper", :user => LIVE_USER)
end
-When /^I connect Gobby to "([^"]+)"$/ do |host|
- gobby = Dogtail::Application.new('gobby-0.5')
- gobby.child('Welcome to Gobby', roleName: 'label')
- gobby.button('Close').click
- # This indicates that Gobby has finished initializing itself
- # (generating DH parameters, etc.) -- before, the UI is not responsive
- # and our CTRL-t is lost.
- gobby.child('Failed to share documents', roleName: 'label')
- gobby.menu('File').click
- gobby.menuItem('Connect to Server...').click
- @screen.type("t", Sikuli::KeyModifier.CTRL)
- connect_dialog = gobby.dialog('Connect to Server')
- connect_dialog.child('', roleName: 'text').typeText(host)
- connect_dialog.button('Connect').click
- # This looks for the live user's presence entry in the chat, which
- # will only be shown if the connection succeeded.
- try_for(60) { gobby.child(LIVE_USER, roleName: 'table cell'); true }
-end
-
When /^the Tor Launcher autostarts$/ do
@screen.wait('TorLauncherWindow.png', 60)
end
diff --git a/features/tor_stream_isolation.feature b/features/tor_stream_isolation.feature
index 8f91218..d0a8386 100644
--- a/features/tor_stream_isolation.feature
+++ b/features/tor_stream_isolation.feature
@@ -29,13 +29,6 @@ Feature: Tor stream isolation is effective
And the Tor Browser loads the startup page
Then I see that Tor Browser is properly stream isolated
- @fragile
- Scenario: Gobby is using the default SocksPort
- When I monitor the network connections of Gobby
- And I start "Gobby" via GNOME Activities Overview
- And I connect Gobby to "gobby.debian.org"
- Then I see that Gobby is properly stream isolated
-
Scenario: SSH is using the default SocksPort
When I monitor the network connections of SSH
And I run "ssh lizard.tails.boum.org" in GNOME Terminal
@@ -47,17 +40,3 @@ Feature: Tor stream isolation is effective
And I query the whois directory service for "boum.org"
And the whois command is successful
Then I see that whois is properly stream isolated
-
- @fragile
- Scenario: Explicitly torify-wrapped applications are using the default SocksPort
- When I monitor the network connections of Gobby
- And I run "torify /usr/bin/gobby-0.5" in GNOME Terminal
- And I connect Gobby to "gobby.debian.org"
- Then I see that Gobby is properly stream isolated
-
- @fragile
- Scenario: Explicitly torsocks-wrapped applications are using the default SocksPort
- When I monitor the network connections of Gobby
- And I run "torsocks /usr/bin/gobby-0.5" in GNOME Terminal
- And I connect Gobby to "gobby.debian.org"
- Then I see that Gobby is properly stream isolated