diff options
authorintrigeri <>2020-05-11 16:05:08 +0000
committerintrigeri <>2020-05-11 16:15:53 +0000
commit6ebe3c9a1ed12628f97791e677edf36cb49e8725 (patch)
parent354deac07444a0304307ae8d4ea1a626f923e004 (diff)
Test suite: fix running with XDG_SESSION_TYPE unset (refs: #17596)
I think this check makes things worse that if were not there, for two reasons. 1. Most users of our test suite run it with sudo, which filters out XDG_SESSION_TYPE from the environment by default, so regardless of whether they're using a Wayland desktop, if they try using --view, a developer using sudo will see this error: ./run_test_suite: line 273: XDG_SESSION_TYPE: unbound variable … which: - is less informative for Wayland users than the error this check was meant to replace; - breaks stuff for folks who don't use Wayland. 2. Even under GNOME + Wayland, when running the test suite under sudo, it turns out that without this check, --view works fine: xtigervncviewer does not error out merely because it detects Wayland, and AFAICT it does its job :)
1 files changed, 0 insertions, 4 deletions
diff --git a/run_test_suite b/run_test_suite
index 4495227..2b11746 100755
--- a/run_test_suite
+++ b/run_test_suite
@@ -282,10 +282,6 @@ TARGET_DISPLAY=$(next_free_display)
if [ -n "${VNC_SERVER:-}" ]; then
- if [ "${XDG_SESSION_TYPE}" != "x11" ]; then
- error "the --view and --vnc-server-only are only supported on x11," \
- "but you use ${XDG_SESSION_TYPE}"
- fi
if [ -n "${VNC_VIEWER:-}" ]; then