summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorintrigeri <intrigeri@boum.org>2019-06-07 09:26:40 +0000
committerintrigeri <intrigeri@boum.org>2019-06-07 09:30:29 +0000
commit7dfe71a3a65b0dab0275ae81cf57c206e5a8e78e (patch)
tree46b05cb7f15b52b04d55bd1c7e0e740dbfa11eac
parent15f508dbad22b52012e00f8d4275bb8a0aa8c324 (diff)
Reviewing guidelines: document how to check APT overlay suites without direct access to our reprepro instance.
We now have reviewers without commit/upload rights. And while I'm at it, replace obsolete mention of "the APT suite" with up-to-date instructions: branches now need to explicitly enable APT overlays.
-rw-r--r--wiki/src/contribute/merge_policy/review.mdwn15
1 files changed, 13 insertions, 2 deletions
diff --git a/wiki/src/contribute/merge_policy/review.mdwn b/wiki/src/contribute/merge_policy/review.mdwn
index 7056d6e..76f2804 100644
--- a/wiki/src/contribute/merge_policy/review.mdwn
+++ b/wiki/src/contribute/merge_policy/review.mdwn
@@ -15,8 +15,19 @@
- Check the diff e.g. with `git log -p`. Beware of changes introduced
by merge commits: either add the `--cc` option to `git log`, or use
`git diff` after reviewing the individual patches.
-- Check the APT suite with
- `ssh reprepro@incoming.deb.tails.boum.org reprepro list [bugfix|feature]-<name-with-dashes>`
+- Check the contents of every APT overlay that the branch enables:
+
+ - If you have upload rights to our [[custom APT
+ repository|contribute/APT_repository/custom]]:
+
+ ssh reprepro@incoming.deb.tails.boum.org \
+ reprepro list ${APT_overlay}`
+
+ - Else:
+
+ - <https://deb.tails.boum.org/dists/${APT_overlay}/main/source/Sources>
+ - <https://deb.tails.boum.org/dists/${APT_overlay}/main/binary-amd64/Packages>
+
- Check the user and design documentation.
- Check the ticket.
- Changes proposed by new contributors, or by the patch'n'forget kind,