summaryrefslogtreecommitdiffstats
path: root/features
diff options
context:
space:
mode:
authorintrigeri <intrigeri@boum.org>2019-01-13 18:20:47 +0000
committerintrigeri <intrigeri@boum.org>2019-01-13 18:38:24 +0000
commit26671c6e2c6361a12d284f0e95cdc78ecce9c146 (patch)
treebc51be257b8a26cc44006f0ec5758e4c87843039 /features
parent904bf71088088936ed5d3d6f6dcc2a068828c664 (diff)
Test suite: when MAC spoofing fails, test safety-critical properties even if the notification is not displayed.
As said on #10774, it's not clear to me whether these scenarios' frequent failure is "merely" (sic) a test suite robustness issue, or an actual bug in Tails. But anyway, MAC spoofing fails, what matters above all is that the network interfaces are disabled and that the real MAC address is not leaked, so let's test this first: this way, even if there's a problem wrt. displaying the notification or wrt. the test suite catching it, by running these scenarios we will at least ensure the user is safe — possibly with poor UX, but safe. refs: #10774
Diffstat (limited to 'features')
-rw-r--r--features/mac_spoofing.feature10
1 files changed, 5 insertions, 5 deletions
diff --git a/features/mac_spoofing.feature b/features/mac_spoofing.feature
index 897cbb3..9bd13e9 100644
--- a/features/mac_spoofing.feature
+++ b/features/mac_spoofing.feature
@@ -36,20 +36,20 @@ Feature: Spoofing MAC addresses
Scenario: MAC address spoofing fails and macchanger returns false
Given macchanger will fail by not spoofing and always returns false
When I log in to a new session
- # XXX: workaround for #11941
- And I see the "Network card disabled" notification after at most 60 seconds
Then no network interfaces are enabled
And no network device leaked the real MAC address
+ # XXX: workaround for #11941
+ And I see the "Network card disabled" notification after at most 60 seconds
#10774
@fragile
Scenario: MAC address spoofing fails and macchanger returns true
Given macchanger will fail by not spoofing and always returns true
When I log in to a new session
- # XXX: workaround for #11941
- And I see the "Network card disabled" notification after at most 60 seconds
Then no network interfaces are enabled
And no network device leaked the real MAC address
+ # XXX: workaround for #11941
+ And I see the "Network card disabled" notification after at most 60 seconds
#10774
@fragile
@@ -57,10 +57,10 @@ Feature: Spoofing MAC addresses
Given macchanger will fail by not spoofing and always returns true
And no network interface modules can be unloaded
When I log in to a new session
- And I see the "All networking disabled" notification after at most 60 seconds
Then 1 network interface is enabled
But the MAC spoofing panic mode disabled networking
And no network device leaked the real MAC address
+ And I see the "All networking disabled" notification after at most 60 seconds
Scenario: The MAC address is not leaked when booting Tails
Given a computer