summaryrefslogtreecommitdiffstats
path: root/wiki/src
diff options
context:
space:
mode:
authorintrigeri <intrigeri@boum.org>2019-04-15 15:50:12 +0000
committerintrigeri <intrigeri@boum.org>2019-04-15 15:50:12 +0000
commit1f5a8c4f7f95a886851fe8ee508958210b8f8214 (patch)
tree2b6a000d230c874656bca43767143b9d20d0c7ee /wiki/src
parent0d95c2e226e4a832de874da4773cab33e93d07f2 (diff)
Clarify how to set the Assignee field when submitting a branch.
As Ulrike pointed out: - The previous phrasing was very unclear. - It's hard to guess whether the FT is able and willing to handle a given review. Better let them decide. - It's not obvious how one can try to find a reviewer by themselves; while regular contributors should hopefully have no trouble doing so, new contributors would be left in doubt. So let's make the default case "empty the Assignee field" and whoever is handling the FT's frontdesk role at a given time (for now: yours truly; some day: rotating role) will dispatch reviews adequately. And hopefully, other team leads have some kind of view that helps the detect pending reviews in their own area, without relying on the FT. refs: #16650
Diffstat (limited to 'wiki/src')
-rw-r--r--wiki/src/contribute/merge_policy/submit.mdwn13
1 files changed, 7 insertions, 6 deletions
diff --git a/wiki/src/contribute/merge_policy/submit.mdwn b/wiki/src/contribute/merge_policy/submit.mdwn
index e50a452..945a405 100644
--- a/wiki/src/contribute/merge_policy/submit.mdwn
+++ b/wiki/src/contribute/merge_policy/submit.mdwn
@@ -27,12 +27,13 @@ When you think it is good enough and have tested it, you have to:
successfully locally, or check that the test suite passes
on Jenkins.
7. Set the ticket's *QA Check* field to *Ready for QA*.
-8. Assign the ticket to nobody (aka. unassign it from yourself) by
- default. Unless it's clear to you that nobody on the
- [[Foundations Team|working_together/roles/foundations_team]] will be
- able or willing to do this specific review; in that case, _you_ shall try
- to find someone else to do the review, and assign the ticket
- to them.
+8. Set the ticket's *Assignee* field appropriately:
+ - If it's already obvious to you who can and should review your branch:
+ assign the ticket to this person.
+ - Else, assign the ticket to nobody, i.e. unassign it from yourself.
+ The [[Foundations Team|working_together/roles/foundations_team]]
+ will either handle the review themselves or help you find a suitable
+ reviewer.
8. For important changes, if you feel the need to ask input from the
greater development community, notify the [[tails-dev@boum.org|about/contact#tails-dev]]
mailing list.